qmk_firmware/keyboards/keychron/c2_pro
Sergey Vlasov b1fbfaaacc
keychron/c2_pro/ansi/white: Fix column 19 in the custom matrix (#21805)
Although `keychron/c2_pro/ansi/rgb` and `keychron/c2_pro/ansi/white` use
the same custom matrix code, the matrix layouts are slightly different;
in particular, only the `keychron/c2_pro/ansi/white` board actually uses
column 19.  However, the handling of column 19 in the custom matrix code
was broken, therefore that column did not work.

Looks like the custom matrix code assumes that `SHIFT_COL_END` refers to
the last column connected to the shift register, and not to the column
past that; so the value of `SHIFT_COL_END` needs to be changed from 19
to 18 (columns 11...18 are connected to the shift register, and column
19 is connected to the C14 pin).

Also the code which was determining `SIZE_T` and `UNSELECT_ALL_COL` had
an off-by-one bug when counting the required number of bits (again due
to the confusion on the `SHIFT_COL_END` meaning); this had been fixed
too (the actual behavior of that part of the code did not change,
because both the old and the new version select the 8 bit variant).
2023-08-23 10:13:03 +01:00
..
ansi
c2_pro.c
config.h keychron/c2_pro/ansi/white: Fix column 19 in the custom matrix (#21805) 2023-08-23 10:13:03 +01:00
halconf.h
info.json
matrix.c keychron/c2_pro/ansi/white: Fix column 19 in the custom matrix (#21805) 2023-08-23 10:13:03 +01:00
mcuconf.h
readme.md

Keychron C2 Pro

Keychron C2 Pro

A customizable 100% keyboard.

  • Keyboard Maintainer: Keychron
  • Hardware Supported: Keychron C2 Pro
  • Hardware Availability: Keychron

Make example for this keyboard (after setting up your build environment):

make keychron/c2/ansi/rgb:default
make keychron/c2/ansi/white:default

Flashing example for this keyboard:

make keychron/c2/ansi/rgb:default:flash
make keychron/c2/ansi/white:default:flash

Reset Key: Hold down the key located at K00, commonly programmed as Esc while plugging in the keyboard.

See the build environment setup and the make instructions for more information. Brand new to QMK? Start with our Complete Newbs Guide.