megamanmalte/hydra
1
0
Fork 0
mirror of https://github.com/NixOS/hydra.git synced 2024-10-22 22:59:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

tests: use like for testing regexes

Browse source 
This gives us better diagnostics when the test fails.
This commit is contained in:
Jörg Thalheim 2024-08-20 08:15:18 +02:00
parent 7de7122479
commit 250780aaf2
4 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
t/Hydra/Controller/Job/builds.t
View file

@ -54,13 +54,14 @@ subtest "/job/PROJECT/JOBSET/JOB/shield" => sub {
subtest "/job/PROJECT/JOBSET/JOB/prometheus" => sub { subtest "/job/PROJECT/JOBSET/JOB/prometheus" => sub {
my $response = request(GET '/job/' . $project->name . '/' . $jobset->name . '/' . $build->job . '/prometheus'); my $response = request(GET '/job/' . $project->name . '/' . $jobset->name . '/' . $build->job . '/prometheus');
ok($response->is_success, "The page showing the job's prometheus data returns 200.");
my $metrics = $response->content;
ok($metrics =~ m/hydra_job_failed\{.*\} 0/); ok($response->is_success, "The page showing the job's prometheus data returns 200.");
ok($metrics =~ m/hydra_job_completion_time\{.*\} [\d]+/);
ok($metrics =~ m/hydra_build_closure_size\{.*\} 96/); my $metrics = $response->content;
ok($metrics =~ m/hydra_build_output_size\{.*\} 96/); like($metrics, qr/hydra_job_failed\{.*\} 0/);
like($metrics, qr/hydra_job_completion_time\{.*\} [\d]+/);
like($metrics, qr/hydra_build_closure_size\{.*\} 96/);
like($metrics, qr/hydra_build_output_size\{.*\} 96/);
}; };
done_testing; done_testing;

2
t/Hydra/Controller/Jobset/http.t
View file

@ -186,7 +186,7 @@ subtest 'Update jobset "job" to have an invalid input type' => sub {
}) })
); );
ok(!$jobsetupdate->is_success); ok(!$jobsetupdate->is_success);
ok($jobsetupdate->content =~ m/Invalid input type.*valid types:/); like($jobsetupdate->content, qr/Invalid input type.*valid types:/);
}; };

2
t/Hydra/Controller/User/dashboard.t
View file

@ -24,7 +24,7 @@ my $cookie = $login->header("set-cookie");
my $my_jobs = request(GET '/dashboard/alice/my-jobs-tab', Accept => 'application/json', Cookie => $cookie); my $my_jobs = request(GET '/dashboard/alice/my-jobs-tab', Accept => 'application/json', Cookie => $cookie);
ok($my_jobs->is_success); ok($my_jobs->is_success);
my $content = $my_jobs->content(); my $content = $my_jobs->content();
ok($content =~ /empty_dir/); like($content, qr/empty_dir/);
ok(!($content =~ /fails/)); ok(!($content =~ /fails/));
ok(!($content =~ /succeed_with_failed/)); ok(!($content =~ /succeed_with_failed/));
done_testing; done_testing;

2
t/api-test.t
View file

@ -115,7 +115,7 @@ subtest "evaluation" => sub {
my $build = decode_json(request_json({ uri => "/build/" . $evals->[0]->{builds}->[0] })->content()); my $build = decode_json(request_json({ uri => "/build/" . $evals->[0]->{builds}->[0] })->content());
is($build->{job}, "job", "The build's job name is job"); is($build->{job}, "job", "The build's job name is job");
is($build->{finished}, 0, "The build isn't finished yet"); is($build->{finished}, 0, "The build isn't finished yet");
ok($build->{buildoutputs}->{out}->{path} =~ /\/nix\/store\/[a-zA-Z0-9]{32}-job$/, "The build's outpath is in the Nix store and named 'job'"); like($build->{buildoutputs}->{out}->{path}, qr/\/nix\/store\/[a-zA-Z0-9]{32}-job$/, "The build's outpath is in the Nix store and named 'job'");
subtest "search" => sub { subtest "search" => sub {
my $search_project = decode_json(request_json({ uri => "/search/?query=sample" })->content()); my $search_project = decode_json(request_json({ uri => "/search/?query=sample" })->content());